Skip to content

fix(document details): browser history modification #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kpsherva merged 1 commit into from
Jun 17, 2026
Merged

fix(document details): browser history modification #1095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 31 additions & 7 deletions ui/src/overridden/frontsite/Document/DocumentDetails/DocumentCirculationExtras.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,39 @@
import React from "react";
import React, { useRef, useEffect } from "react";
import _get from "lodash/get";
import _isEmpty from "lodash/isEmpty";
import { invenioConfig } from "@inveniosoftware/react-invenio-app-ils";
import { Embed, Button, Divider, Icon } from "semantic-ui-react";
import { Button, Divider, Icon } from "semantic-ui-react";
import PropTypes from "prop-types";
import { renderCallNumber, shelfLink } from "../../../utils";

// Uses location.replace() so iframe navigation (including server-side redirects)
// doesn't add extra entries to the browser's joint session history.
// eslint-disable-next-line react/prop-types
function MapIframe({ url }) {
const iframeRef = useRef(null);
useEffect(() => {
if (iframeRef.current) {
iframeRef.current.contentWindow.location.replace(url);
}
}, [url]);
return (
<div className="ui active embed cern-map">

@sakshamarora1 sakshamarora1 Jun 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the<Embed> component not working with replace url?

@kpsherva kpsherva Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the implementation of embed was causing the redundant entries added to the history of the browser, like the comment over the new function mentions

<div className="embed">
<iframe
ref={iframeRef}
src="about:blank"
frameBorder={0}
allowFullScreen={false}
scrolling="no"
width="100%"
height="100%"
title="Find it on shelf map"
/>
</div>
</div>
);
}

function canCirculateItem(item) {
return invenioConfig.ITEMS.canCirculateStatuses.includes(item.status);
}
Expand Down Expand Up @@ -77,11 +105,7 @@ export class DocumentCirculationExtras extends React.Component {
return (
<>
<Divider />
<Embed
className="cern-map"
active
url={shelfLink(shelfNumber, { iframe: true })}
/>
<MapIframe url={shelfLink(shelfNumber, { iframe: true })} />
<Button
as="a"
smooth
Expand Down
Loading