common BUGFIX define PATH_MAX if not available#2404
Merged
Conversation
michalvasko
requested changes
Jun 3, 2025
Member
michalvasko
left a comment
michalvasko
left a comment
There was a problem hiding this comment.
uncrustify requires includes to be sorted alphabetically, that is why the tests failed.
PATH_MAX is optional in POSIX, and thus may not be provided (e.g. on GNU/Hurd). Provide a fallback definition for it, so the existing code keeps working for now; include <limits.h> to ensure that PATH_MAX is available if provided on the current OS/libc.
Contributor
Author
No problem - fixed :) |
michalvasko
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PATH_MAXis optional in POSIX, and thus may not be provided (e.g. on GNU/Hurd). Provide a fallback definition for it, so the existing code keeps working for now; include<limits.h>to ensure thatPATH_MAXis available if provided on the current OS/libc.