Skip to content

yanglint UPDATE extension validation #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalvasko merged 6 commits into from
Jul 15, 2025
Merged

yanglint UPDATE extension validation #2413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
edccb40
examples UPDATE extension parsing and validation
Ardival Jul 8, 2025
2047d59
yanglint UPDATE extension parsing and validation
Ardival Jul 8, 2025
280b7b7
added feature extension parsing - in progress
Ardival Jul 11, 2025
8cb8545
yanglint UPDATE extension validation
Ardival Jul 14, 2025
b456cf6
printing of extension fixed
Ardival Jul 14, 2025
829499c
added constrains for extension parsing
Ardival Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/yanglint/interactive/data_operational.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
source [expr {[info exists ::env(TESTS_DIR)] ? "$env(TESTS_DIR)/interactive/ly.tcl" : "ly.tcl"}]

set ddir "$::env(TESTS_DIR)/data"
set err1 "Operational datastore takes effect only with RPCs/Actions/Replies/Notification input data types"
set err1 "Operational datastore takes effect only with RPCs/Actions/Replies/Notification/Extensions input data types"

test data_operational_twice {it is not allowed to specify more than one --operational parameter} {
-setup $ly_setup -cleanup $ly_cleanup -body {
Expand Down
2 changes: 1 addition & 1 deletion tests/yanglint/non-interactive/data_operational.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ source [expr {[info exists ::env(TESTS_DIR)] ? "$env(TESTS_DIR)/non-interactive/

set mdir "$::env(YANG_MODULES_DIR)"
set ddir "$::env(TESTS_DIR)/data"
set err1 "Operational datastore takes effect only with RPCs/Actions/Replies/Notification input data types"
set err1 "Operational datastore takes effect only with RPCs/Actions/Replies/Notification/Extensions input data types"

test data_operational_twice {it is not allowed to specify more than one --operational parameter} {
ly_cmd_err "-t notif -O $ddir/modconfig.xml -O $ddir/modleaf.xml" "cannot be set multiple times"
Expand Down
2 changes: 1 addition & 1 deletion tools/lint/cmd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ COMMAND commands[] = {
},
{
"data", cmd_data_opt, cmd_data_dep, cmd_data_store, cmd_data_process, cmd_data_help, NULL,
"Load, validate and optionally print instance data", "d:ef:F:hmo:O:R:r:nt:x:"
"Load, validate and optionally print instance data", "d:ef:F:hmo:O:R:r:nt:x:k:"
},
{
"list", cmd_list_opt, cmd_list_dep, cmd_list_exec, NULL, cmd_list_help, NULL,
Expand Down
9 changes: 9 additions & 0 deletions tools/lint/cmd.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,15 @@ int cmd_debug_dep(struct yl_opt *yo, int posc);
*/
int cmd_debug_store(struct ly_ctx **ctx, struct yl_opt *yo, const char *posv);

/**
* @brief Store the values: mod_name, name, argument of extension.
*
* @param[in] extension_id String in format "<module-name>:<extension-name>:<argument>".
* @param[in,out] yo Options for yanglint.
* @return 0 on success.
*/
int parse_ext_string(const char *extension_id, struct yl_opt *yo);

/**
* @brief Set debug logging.
*
Expand Down
Loading