Load Extensions Early and Differentiate Client/Server Logs#79
Open
Load Extensions Early and Differentiate Client/Server Logs#79
Conversation
…ient Always send clients all of the testing framework so clientside tests can be enabled/disabled at will Run clientside tests after serverside tests finish
Load extensions immediately instead of waiting for the tests to run so that clients receive them in time
…est logs in situations where the text color isn't present
…FC-Servers/GLuaTest into feature_improve-client-support
sarahsturgeon
requested changes
May 1, 2025
Member
sarahsturgeon
left a comment
sarahsturgeon
left a comment
There was a problem hiding this comment.
Will test locally, but also a discussion about prefixed logs
Comment on lines
+18
to
+24
| if SERVER then | ||
| prefixText = "sv_" .. prefixText | ||
| prefixColor = colors.server | ||
| else | ||
| prefixText = "cl_" .. prefixText | ||
| prefixColor = colors.client | ||
| end |
Member
There was a problem hiding this comment.
I don't love this.
Could we maybe only prefix them if the clientside convar is enabled, or similar? Or, perhaps, only prefix the client tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves extension loading to be immediate rather than waiting until tests are running.
Because extensions
AddCSLuaFile()themselves, clients connecting before the server tests run wouldn't download the extensions previously. Now, they do.It also adds a
cl_andsv_prefix to logs to further differentiate the two realms for cases where text color doesn't work and for color-blind accessibility.