Skip to content

feat: rewrite rngs reading logic and make get_abstract_state compatib…#4

Merged
mesakhcienet merged 2 commits into
mesa/migrate-modelspy-to-nnxfrom
jackyf/nnx_porting
Nov 11, 2025
Merged

feat: rewrite rngs reading logic and make get_abstract_state compatib…#4
mesakhcienet merged 2 commits into
mesa/migrate-modelspy-to-nnxfrom
jackyf/nnx_porting

Conversation

@RexBearIU

Copy link
Copy Markdown

Description

This is a draft PR to porting maxtext linen model to nnx

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.

Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@mesakhcienet mesakhcienet marked this pull request as ready for review November 11, 2025 08:50
@mesakhcienet mesakhcienet merged commit 825a47b into mesa/migrate-modelspy-to-nnx Nov 11, 2025
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants