Conversation
全模型全渠道附件上传deepseek功能 全接口兼容性待测试
Co-authored-by: traeagent <traeagent@users.noreply.github.com>
feat: 增强工具调用解析能力，支持 XML 命名参数和 CDATA
|
@POf-L is attempting to deploy a commit to the cjack's projects Team on Vercel. A member of the Team first needs to authorize it. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b98b541ae
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if strings.Contains(v, "\n") { | ||
| return strings.Trim(v, "\n") | ||
| } |
There was a problem hiding this comment.
normalizeToolParamValue now strips only \n at the edges, so pretty-printed arguments like <parameter name="path">\n README.md\n</parameter> are normalized to " README.md" (and CRLF input can retain \r). These values are forwarded as tool arguments, which can break path/command-style tools that expect exact tokens; before this change these values were TrimSpaced. Please keep multiline-content preservation without leaving structural indentation on scalar arguments.
Useful? React with 👍 / 👎.
| if (s.includes('\n')) { | ||
| return s.replace(/^\n+/, '').replace(/\n+$/, ''); | ||
| } |
There was a problem hiding this comment.
The JS stream parser mirrors the same regression: for any value containing a newline, normalizeParamValue removes only leading/trailing newlines and preserves surrounding spaces. A common formatted payload (<parameter name="path">\n README.md\n</parameter>) becomes " README.md", so streamed tool-call arguments can carry invalid path/command values even though they are just XML indentation artifacts.
Useful? React with 👍 / 👎.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
这里codexreview的一些边际问题可能还要仔细处理一下 |
2 participants
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
📝 补充信息 | Additional Information