Repository navigation
Fix seamless loop / Spotify Canvas export (xfade frame rate) and four small UI issues - #861
Conversation
…dge secret badge, panel rebuild - Export: add fps=<fps> after each setpts in the loop filter graph. xfade needs a constant frame rate and ffmpeg exited with code 234 for the Seamless loop and Spotify Canvas profiles. Verified with a real ffmpeg run. - Visualizer panel: Placement rebuilds the panel so Floor Reflection shows at once; Reflection Length no longer depends on the reflection value. - i18n: the "Screen" blend option has its own label key, so "Display" stays correct for the display section. - Audio bridge window: report the missing pairing secret in bridge-only mode instead of "Starting" forever. - Studio list: full preset name as a tooltip when the name is cut off. - Tests for each; layout import behaviour with a text element is documented by a test. - Docs test count 3582; CHANGELOG entry.
|
CaYaDraft — pull request Summary Files
Note Stopping here. I will not merge, push, or change this pull request until you ask.
|
Fixes from the latest Linux retest (v3.1.6, 614dbab).
Fixed
ffmpeg exit code 234 ... xfade ... current rate of 1/0 is invalid. Aftertrimandsetptsthe two branches had no frame rate andxfadeneeds one.loopPlannow addsfps=<fps>after eachsetpts=PTS-STARTPTS. Checked with a real ffmpeg 7.1 run throughbuildArgs(320x180, 2 s, 30 fps): before the change exit 234; after it exit 0, 60 frames, yuv420p, 30 fps, 2.000 s.rebuild: true, and Reflection Length no longer waits for the reflection slider to be above 0 (sliders do not rebuild the panel).send: false). It now shows "Secret missing".Layout import (#4), by design, no code change: a layout file with a text element adds a second visualizer-type layer, because text is a sub-type of the visualizer layer. A fresh scene ends up with [background, visualizer(bars), visualizer(text)]; importing the same file again updates those layers (updated 2, added 0). Covered by a test.
Skipped:
sv_list_modeslabels stay Turkish. The mode catalog labels live in the renderer sources and the English dictionary is not available in the main process, so it is not a cheap change; the ids are language independent.Tests:
npm test3582 tests, 0 fail (3 skipped on this machine, environment dependent). New tests cover the loop graph, the Screen label, the Placement rebuild, the layout import and the bridge status. README.md, README.tr.md and ROADMAP.md counts set to 3582; CHANGELOG entry added.