fix: type of Rule constructor and Rule's name#397
Merged
chris-pardy merged 2 commits intoCacheControl:v8from Nov 20, 2024
Merged
fix: type of Rule constructor and Rule's name#397chris-pardy merged 2 commits intoCacheControl:v8from
chris-pardy merged 2 commits intoCacheControl:v8from
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the types suggest that Rule needs an argument for its construction, but it doesn't. And when it is constructed without an argument, its
namewill be undefined. This PR adds a test to document this behavior and changes the types accordingly. It is targeted to v8 because the change to the type ofRule.nameis technically breaking.