feat: advisory locks for cron singleton#563
Open
joelmadaki77-cyber wants to merge 1 commit into
Open
Conversation
Use pg_try_advisory_lock to ensure only one replica runs a given cron job at a time. - src/workers/lockHelper.ts: withAdvisoryLock(pool, key, logger, fn) acquires a session-level advisory lock on a dedicated client, runs fn, then releases. Skips (returns false) on contention. Throws TypeError for non-integer keys. Client is always released. - src/services/idempotencySweeper.ts: refactored to delegate lock acquisition/release to withAdvisoryLock. - src/workers/lockHelper.test.ts: 7 tests covering acquire/run/release, skip on contention, rethrow on fn error, unlock failure logged, TypeError for non-integer key, client release on query error, missing rows treated as not-acquired. - src/services/idempotencySweeper.test.ts: updated mocks to use pool.connect() pattern required by withAdvisoryLock. Closes CalloraOrg#475
|
@joelmadaki77-cyber Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use pg_try_advisory_lock to ensure only one replica runs a given cron job at a time.
Closes #475