feat: add rate-limit pre-check endpoint /api/limits/check#569
Merged
greatest0fallt1me merged 2 commits intoJun 28, 2026
Conversation
- Add peek() method to InMemoryRestRateLimiter (no token consumption) - Create GET /api/limits/check endpoint returning ok|deny with reason - Scope auth to caller via requireAuth - Add 1-second per-key cache for efficiency - Add comprehensive tests for peek() and the endpoint
|
@Derry255 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Merged via direct push to main (admin) |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a rate-limit pre-check endpoint
GET /api/limits/checkthat tells the client whether the next call would succeed without consuming budget (dry-run). It reuses the existingInMemoryRestRateLimiterand adds a non-consumingpeek()method.Related Issue
Closes #477
Changes
🔍 Rate Limiter Peek
src/middleware/restRateLimit.ts— Addedpeek(key, now)method toInMemoryRestRateLimiterthat reads the current bucket state without creating or modifying it. Returns{ allowed: boolean; retryAfterMs?: number }.🛣️ New Endpoint
[ADD]
src/routes/limits.ts— NewGET /api/limits/checkroute:{ status: "ok" }when the caller has remaining budget{ status: "deny", reason: "rate_limit_exceeded", retryAfterMs }when the limit is exceededrequireAuth(JWT Bearer orx-user-idheader)peek()instead ofcheck())[MODIFY]
src/routes/index.ts— AddedrestRateLimiterdep and mounted/limitsrouter under the API.[MODIFY]
src/app.ts— Refactored to create theInMemoryRestRateLimiterinstance explicitly and pass it via deps to both the rate-limit middleware and the limits router.🧪 Tests
[ADD]
src/middleware/restRateLimit.test.ts— 6 new tests coveringpeek():[ADD]
src/routes/limits.test.ts— 9 new tests covering the endpoint:Verification Results