Skip to content

feat: revenue_pool pause guardian#551

Merged
greatest0fallt1me merged 1 commit into
CalloraOrg:mainfrom
Jerry-Tekh:feature/pool-guardian
Jun 27, 2026
Merged

feat: revenue_pool pause guardian#551
greatest0fallt1me merged 1 commit into
CalloraOrg:mainfrom
Jerry-Tekh:feature/pool-guardian

Conversation

@Jerry-Tekh

Copy link
Copy Markdown
Contributor

Summary

  • Add an admin-managed pause_guardian role to callora-revenue-pool
  • Allow the guardian to call pause only; unpause, distribution, admin rotation, cap updates, guardian management, and upgrades remain admin-only
  • Add guardian set/clear events, focused tests, and interface/access-control documentation

Tests

  • cargo test -p callora-revenue-pool (83 passed)
  • cargo clippy -p callora-revenue-pool --all-targets --all-features -- -D warnings
  • rustfmt --check contracts/revenue_pool/src/lib.rs contracts/revenue_pool/src/events.rs contracts/revenue_pool/src/test.rs contracts/revenue_pool/src/test_invariant.rs
  • python3 -m json.tool docs/interfaces/revenue_pool.json
  • git diff --check

Notes

  • cargo test --workspace currently fails outside this change before completing because existing settlement/vault tests are out of sync with their contract APIs, including stale withdraw_developer_balance call arity in settlement tests and duplicate/missing revenue-pool setter tests in vault tests.
  • cargo fmt --all -- --check reports formatting diffs in existing non-revenue-pool files; the touched revenue-pool Rust files pass rustfmt --check.

Closes #530

@greatest0fallt1me

Copy link
Copy Markdown
Contributor

Merged via direct push to main (admin)

@greatest0fallt1me greatest0fallt1me merged commit 1c7a953 into CalloraOrg:main Jun 27, 2026
@Jerry-Tekh

Copy link
Copy Markdown
Contributor Author

Summary

  • Add an admin-managed pause_guardian role to callora-revenue-pool
  • Allow the guardian to call pause only; unpause, distribution, admin rotation, cap updates, guardian management, and upgrades remain admin-
    only
  • Add guardian set/clear events, focused tests, and interface/access-control documentation

Tests

  • cargo test -p callora-revenue-pool (83 passed)
  • cargo clippy -p callora-revenue-pool --all-targets --all-features -- -D warnings
  • rustfmt --check contracts/revenue_pool/src/lib.rs contracts/revenue_pool/src/events.rs contracts/revenue_pool/src/test.rs contracts/ revenue_pool/src/test_invariant.rs
  • python3 -m json.tool docs/interfaces/revenue_pool.json
  • git diff --check

Notes

  • cargo test --workspace currently fails outside this change because existing settlement/vault tests are out of sync with their contract APIs.
  • cargo fmt --all -- --check reports formatting diffs in existing non-revenue-pool files; touched revenue-pool Rust files pass rustfmt --check.

Closes #530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add revenue_pool emergency pause guardian

2 participants