feat: settlement OverDraft variant (#531)#577
Open
NEA-DEV-coder wants to merge 1 commit into
Open
Conversation
Add SettlementError::OverDraft = 23 to distinguish overdraft attempts (withdrawal amount > developer balance) from other insufficient-balance conditions. Replace InsufficientDeveloperBalance in withdraw_developer_balance with OverDraft. - errors.rs: add OverDraft = 23 variant with doc comment - lib.rs: return OverDraft instead of InsufficientDeveloperBalance - test_error_codes.rs: add mapping + doc line assertion for OverDraft - docs/ERROR_CODES.md: add row 23 to Settlement table Closes CalloraOrg#531
|
@NEA-DEV-coder Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@GBOYEE has applied to work on this issue as part of the Stellar Wave Program's 6th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @GBOYEE to this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
SettlementError::OverDraft = 23to the settlement contract, providing a dedicated, semantically distinct error for overdraft attempts (withdrawal amount exceeds developer balance).Changes
contracts/settlement/src/errors.rs— newOverDraft = 23variant with///rustdoc and doc-table rowcontracts/settlement/src/lib.rs—withdraw_developer_balancenow returnsOverDraftinstead ofInsufficientDeveloperBalancewhenamount > current_balancecontracts/settlement/src/test_error_codes.rs— added(23, OverDraft)mapping, bumped uniqueness assertion to 23, added doc-line checkdocs/ERROR_CODES.md— added row 23 to the Settlement tableAcceptance criteria
OverDraftvariant at stable code 23withdraw_developer_balanceoverdraft guardtest_error_codes.rsuniqueness + doc-line tests updatedCloses #531