Stream shell output to the TUI tail - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Streams host shell stdout/stderr live into the existing TUI/log tail while preserving the final shell result envelope.
Long-running shell commands now show progress during execution instead of appearing inactive until completion.
What changed
Added live
ShellOutputChunkevents for host shell stdout/stderrThreaded optional shell streaming through shell execution only
Rendered live shell chunks in the existing TUI/log tail
Displays stdout as
out>and stderr aserr>Preserved the final shell result envelope:
stdoutstderrtimed_outtimeout_msstatusKept CLI projected JSON unchanged
Kept JSONL/tail event output bounded
Memory and throttling behavior
try_send[live output truncated; see final result]max_log_linesWhy
PR #15 made shell execution bounded.
PR #16 preserved useful head/tail output after completion.
PR #17 added a default timeout policy.
This PR closes the remaining shell UX gap: the user can now see command progress while a long shell command is still running.
Validation
cargo fmt --checkcargo clippy --all-targets -- -D warningscargo test --lib target::cargo test --lib tools::cargo test --test tool_call_accuracy_cicargo test --lib reprocargo test --test artifact_goldenpython scripts/ci_release_readiness.pycargo testAll validation passed locally.
Follow-ups