WhitelistProvider is now an interface#121
Closed
jamierocks wants to merge 2 commits intoCanaryModTeam:masterfrom
jamierocks:feature/whitelist
Closed
WhitelistProvider is now an interface#121jamierocks wants to merge 2 commits intoCanaryModTeam:masterfrom jamierocks:feature/whitelist
jamierocks wants to merge 2 commits intoCanaryModTeam:masterfrom
jamierocks:feature/whitelist
Conversation
I left BackboneWhitelist, so you can decide on weather to keep it :)
Member
|
I'm not following the logic in making this an Interface. |
Member
Author
|
It is unable to be easily implementated on platforms such as Forge as it currently is |
Member
|
@jamierocks I don't get why ReserveList and Operators are not done the same here also. |
Member
Author
|
I realized that after I made the pr. I will update later on. |
Member
Author
|
Replaced by #129. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I left BackboneWhitelist, so you can decide on weather to keep it :)