fix: prevent Host Header Injection in image upload route#103
Open
Siddh2024 wants to merge 1 commit into
Open
Conversation
The image URL construction used req.get('host') directly from the request
header, allowing attackers to inject malicious URLs via a crafted Host
header. Now uses a configurable BASE_URL environment variable, falling
back to the request host only when not set.
Fixes Canopus-Labs#93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #93
Bug
In
backend/routes/authRoutes.js:24, the image URL was constructed usingreq.get("host")directly from the incoming request header, allowing Host Header Injection.Fix
req.get("host")with a configurableBASE_URLenvironment variableBASE_URLdocumentation to.env.exampleBASE_URLis not set