Skip to content

chore: sync upstream PR #8458 - fix(cli): iOS allow provision update on build xArchieve#72

Open
riderx wants to merge 2 commits into
plusfrom
sync/upstream-pr-8458
Open

chore: sync upstream PR #8458 - fix(cli): iOS allow provision update on build xArchieve#72
riderx wants to merge 2 commits into
plusfrom
sync/upstream-pr-8458

Conversation

@riderx
Copy link
Copy Markdown
Member

@riderx riderx commented May 7, 2026

Upstream PR Sync

This PR syncs changes from an external contributor's PR on the official Capacitor repository.

Original PR

  • PR: #8458
  • Title: fix(cli): iOS allow provision update on build xArchieve
  • Author: @EltonFaust

Automation

  • CI will run automatically
  • Claude Code will review for security/breaking changes
  • If approved, this PR will be auto-merged
  • A new release will be published automatically

Synced from upstream by Capacitor+ Bot

Summary by CodeRabbit

  • Bug Fixes
    • Improved iOS app builds to automatically handle provisioning updates during the build process when automatic signing is configured, enhancing build reliability.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3a96057a-ad48-43d1-99b2-ffb0821d2660

📥 Commits

Reviewing files that changed from the base of the PR and between f3aefab and 180d2ff.

📒 Files selected for processing (1)
  • cli/src/ios/build.ts

📝 Walkthrough

Walkthrough

The PR modifies the iOS build command construction to add -allowProvisioningUpdates to the initial xcodebuild archive step when automatic signing is active, rather than limiting this flag to the export step. This enables provisioning profile updates during the archive phase for non-manual signing configurations.

Changes

iOS Build Configuration

Layer / File(s) Summary
Archive Arguments Configuration
cli/src/ios/build.ts
The xcodebuild argument list branches on xcodeSigningType: manual signing pushes PROVISIONING_PROFILE_SPECIFIER, while automatic signing now pushes -allowProvisioningUpdates to the initial archive step.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A flag slips in, so neat and small,
To let those profiles dance and sprawl,
No manual fuss, just let it breathe,
The archive builds what's underneath! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: syncing an upstream PR that fixes iOS provisioning updates during xcodebuild archive operations.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/upstream-pr-8458

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants