Show commander tax in perpetual mana cost overlay#10258
Open
MostCromulent wants to merge 1 commit intoCard-Forge:masterfrom
Open
Show commander tax in perpetual mana cost overlay#10258MostCromulent wants to merge 1 commit intoCard-Forge:masterfrom
MostCromulent wants to merge 1 commit intoCard-Forge:masterfrom
Conversation
When the "perpetual mana cost" overlay is enabled, commanders in the
command zone now show their mana cost including accumulated commander
tax ({2} per previous cast). The tax is layered dynamically on top of
any existing perpetual cost adjustments in the getter, keeping the
perpetual calculation pipeline unchanged.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design notes
Scope: The overlay shows permanent/intrinsic modifiers only (perpetual effects + commander tax), not external battlefield-state cost modifiers like Foundry Inspector. Similarly, cards that specifically offset commander tax — like Myth Unbound ({1} less per cast) or Liesa, Shroud of Dusk (pay life instead of tax) — are not reflected in the overlay. This is an existing limitation of the perpetual overlay — it has never accounted for external modifiers — and commander tax doesn't change that.
View update trigger: The mana cost overlay reads from a cached trackable property, so it needs an explicit
updateManaCostForView()call to refresh. Three locations were considered:Player.incCommanderCast()— card is on the stack when this fires, so the zone-gated getter returns base cost (no effect)GameAction.changeZone()— multiple branches need the trigger, andsetPerpetual()fires before the zone is setCard.setZone()— fires after zone assignment, single point for all transitions, gated behindisCommander(), consistent with the 50+ existingview.update*()calls inCard.javaCard.setZone()was chosen for simplicity and completeness.🤖 Generated with Claude Code