Don't search library while opponent controls Ob Nixilis, Unshackled (#8346)#8347
Conversation
|
This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed |
11c2901 to
3ad062a
Compare
tool4ever
left a comment
There was a problem hiding this comment.
checks are once again just too vague, e.g. this would also stop other kind of hidden mode zone changing when the cards are in play
I did the explicit name first, then rewrote it to be generic to address #8347 (comment) and that matches only the one card last i checked, so I don't see how it's too vague now. Is it my addition of Opposition Agent effects? "ControlOpponentsSearchingLibrary" sounds like something you also don't want to trigger with a library search. |
|
you're not considering the bigger picture which would cause negative impact: the method is in fact already named "hiddenOriginCanPlayAI" to express it handles way more variants |
|
So this patch isn't broad enough? What else should it cover? |
|
It's possible to search other libraries than your own... |
71cb223 to
8ae396e
Compare
Fixes #8346.
Test result from game log (why is that most recent on top?):