Skip to content

condition edit/add/delete modal#2705

Merged
bcb37 merged 3 commits into
experiment-design-refreshfrom
feature/2679-condition-modal
Nov 6, 2025
Merged

condition edit/add/delete modal#2705
bcb37 merged 3 commits into
experiment-design-refreshfrom
feature/2679-condition-modal

Conversation

@bcb37
Copy link
Copy Markdown
Collaborator

@bcb37 bcb37 commented Oct 27, 2025

No description provided.

@bcb37 bcb37 linked an issue Oct 27, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements functionality for adding, editing, and deleting experiment conditions through a modal dialog interface. The changes enable users to manage conditions via a dedicated modal component with autocomplete support and proper validation.

Key Changes

  • Added new UpsertConditionModalComponent for creating and editing conditions with autocomplete functionality
  • Implemented condition CRUD operations through a new ConditionHelperService
  • Added Redux actions, reducers, and effects to handle condition updates
  • Connected the UI components to trigger the new modal dialogs

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
en.json Added translation key for condition hint text
common-dialog.service.ts Added modal service methods for add/edit/delete condition dialogs
experiment-conditions-section-card.component.ts Connected UI actions to modal service methods
experiment-conditions-section-card.component.html Updated template to pass context parameter
upsert-condition-modal.component.ts New modal component with form validation and autocomplete
upsert-condition-modal.component.html Modal template with condition and description fields
experiments.reducer.ts Added reducer handlers for condition update actions
experiments.model.ts Added new interfaces for condition operations
experiments.effects.ts Added effect to handle condition update requests
experiments.actions.ts Added Redux actions for condition updates
experiments.service.ts Added service method to dispatch condition updates
experiments.data.service.ts Added data service method for API calls
condition-helper.service.ts New service implementing condition CRUD logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread frontend/projects/upgrade/src/app/core/experiments/store/experiments.model.ts Outdated
Comment thread frontend/projects/upgrade/src/app/core/experiments/condition-helper.service.ts Outdated
bcb37 and others added 2 commits October 27, 2025 16:18
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@bcb37 bcb37 merged commit 30eec44 into experiment-design-refresh Nov 6, 2025
8 checks passed
@bcb37 bcb37 deleted the feature/2679-condition-modal branch November 6, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Simplified Add Condition Modal for Experiments

3 participants