add missing types build to publishing action#3074
Open
danoswaltCL wants to merge 3 commits intorelease/6.4from
Open
add missing types build to publishing action#3074danoswaltCL wants to merge 3 commits intorelease/6.4from
danoswaltCL wants to merge 3 commits intorelease/6.4from
Conversation
bcb37
requested changes
Apr 15, 2026
Collaborator
bcb37
left a comment
bcb37
left a comment
There was a problem hiding this comment.
This isn't going to work now that there's no package-lock.json in the directory. We have to install the deps from the top-level using yarn.
danoswaltCL
force-pushed
the
bugfix/add-missing-types-build-to-publish-action
branch
from
297f336 to
cd0e217
Compare
Collaborator
Author
|
%&$()&$) why the f are these tests failing now, the changes are all in the .github and clientlib folders. i just want to publish this stupid package |
Collaborator
Author
|
ok there we go. i tested out these steps locally to emulate and it seems like it should work:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.