[ENG-9250] Some registration schema fields not displaying or formatting correctly in Angular UI#683
Conversation
futa-ikeda
left a comment
futa-ikeda
left a comment
There was a problem hiding this comment.
I think this fix should address the two discrepancies I found between production and staging5. I think my biggest concern here is that there are currently some assumptions baked into how these sections/questions relate to each other, and some assumptions in the code being made when creating each currentSection and currentQuestion object, but this is going to be a discussion with Product team moreso than anything.
It also looks like some of the analysis I did in the original ticket weren't quite right, as I don't think it's the helpText attr being overwritten, necessarily.
| ContributorsInput = 'contributors-input', | ||
| SelectOtherOption = 'select-other-option', |
There was a problem hiding this comment.
We can remove this, as these haven't been used and I don't think there are plans to use this in the future.
| @if (q.helpText && q.fieldType !== FieldType.Radio && q.fieldType !== FieldType.Checkbox) { | ||
| <p>{{ q.helpText }}</p> | ||
| @if (q.helpText) { |
There was a problem hiding this comment.
Does this update the issue outlined in the ticket ("Another one that’s not showing up is the help_text..." ). I think the root cause of the problem that's outlined in that ticket is not addressed where we use a currentQuestion object to store helpText, but this helpText can be overwritten in subsequent blocks.
Edit: it looks like the original analysis wasn't correct, as I thought we were overriding currentQuestion.helpText with SelectSingleInputOption, but this is setting helpText for a member in the currentQuestion?.options array
nsemets
merged commit e65d926
into
CenterForOpenScience:feature/pbs-25.01
2 participants
Summary of Changes
Screenshot(s)