[ANG-9250] P3.5 - Some registration schema fields not displaying or formatting correctly in Angular UI

[nsemets]

• Ticket: [ANG-9250]
• Feature flag: n/a

Summary of Changes

1. Fixed display of schema blocks.

[brianjgeiger]

We'll be changing the branch to feature/pbs-25.02 once it's finished pushing to centerforopenscience.

[brianjgeiger]

@nsemets Please rebase on feature/pbs-25.02

[futa-ikeda]

Note for posterity, this addresses an issue where certain questions were not showing up in the overview page. This was stemming from the fact that there was an implicit assumption in how we were rendering forms before where we assumed the blocks would show up in an order like PageHeading -> SectionHeading -> QuestionLabel, but that is not necessarily the case

[futa-ikeda]

Looks good! Just a couple places where we may be able to avoid similar issues in the future

[futa-ikeda]

Leaving a note here to describe the problem for ourselves in the future. The issue that was appearing was that certain sections of the registration template would not appear in the submission and the overview page

Missing sections on the submission page:

• This issue would occur when multiple, back-to-back paragraph block types were in a template. The subsequent paragraph blocks would override the contents of the previous paragraph block that was stored in currentSection.description. The fix is to append the paragraph content to the existing description

Missing sections in the review and overview pages:

• This issue was caused by the fact that there was a subtle assumption being made when rendering that schemas would follow the pattern of PageHeading -> SectionHeading -> QuestionLabel, but schemas may just go PageHeading -> QuestionLabel directly (skipping SectionHeading)