[ENG-10328] fixed non-consistent COI#11633
Open
ihorsokhanexoft wants to merge 27 commits intoCenterForOpenScience:feature/pbs-26-6from
Open
[ENG-10328] fixed non-consistent COI#11633ihorsokhanexoft wants to merge 27 commits intoCenterForOpenScience:feature/pbs-26-6from
ihorsokhanexoft wants to merge 27 commits intoCenterForOpenScience:feature/pbs-26-6from
Conversation
* Update RegistrationActionSerializer * Update RegistrationActionSerializer
…e service type (CenterForOpenScience#11543) * get default_license_id on preprint creation to handle it on FE (looks like it is not used drafts/id/metadata) for prepints in browser url so for get request is is redundant get default_license_id on draft registration creation (to get for FE after creation) and also for GET/ request to get it on drafts/id/metadata request * implement asc sorting for admin brand tab and showing brand related unique provider types
* Update share * Fix manage command
…ojects in API (CenterForOpenScience#11425) * add include_children to delete contributors * atomic contributor remove; add tests * remove from children only for nodes * fix tests --------- Co-authored-by: Yuhuai Liu <yuhuai@cos.io>
…CenterForOpenScience#11397) * fixed affiliation update for write contributors in registrations * removed redundant blank line * fixed tests * fixed tests * fixed a test * don't expect errors in tests
…CenterForOpenScience#11567) * if preprint is pending moderation show it for not contributors/moderators/Logged-out users using /pending-moderation redirection on access * update testcases to be it compatable with 'This preprint is pending moderation and is not yet publicly available.' logic * test update * test update * test update
…n FE (looks like it is not used drafts/id/metadata) for prepints in browser url so for get request is is redundant (CenterForOpenScience#11464) get default_license_id on draft registration creation (to get for FE after creation) and also for GET/ request to get it on drafts/id/metadata request
…enScience#11420) * add list_serializer_class for NodeContributorsCreateSerializer; minor optimization * add bulk add_contributor_registered_or_not method * Use DRY for NodeContributorsBulkCreateListSerializer * fix changes after notification refactor * add default email_preferences to NodeContributorsBulkCreateListSerializer
CenterForOpenScience#11568) * update gdpr delete logic * fix test; better error handling
…nterForOpenScience#11285) * [ENG-8514] Remove CSRF protection from reset password api v2 POST (CenterForOpenScience#11246) * remove csrf protection from reset password endpoint * update test * add background color prop to Brand (CenterForOpenScience#11254) * fix flaky test_serialized_metadata * fix throttle test * reset throttle cache * don't ignore components when create a view-only link * fixed updating subscribe_osf_general_email subscription * [ENG-7277] Update doc to include version as relationship (CenterForOpenScience#11262) * added tests * [ENG-8691] Wrong server on reset password email (CenterForOpenScience#11271) * use same logic for admin and web password reset * fix tests * enable filtering for linked-nodes endpoint (CenterForOpenScience#11273) * remove deleted users from institutional dashboard (CenterForOpenScience#11261) * fixed tests * [ENG-7803] Update text on VOL modal for registration (CenterForOpenScience#11279) * add a file removal feature for a node (registration) using admin panel * delete file only for archived registration when it is not possible from user side to avoid inconsistency * remove file from scheme response blocks * delete file from registration and metadata and keep it for original project --------- Co-authored-by: antkryt <ant.krytskyi@gmail.com> Co-authored-by: John Tordoff <Johnetordoff@users.noreply.github.com> Co-authored-by: Ihor Sokhan <isokhan@exoft.net> Co-authored-by: Vlad0n20 <137097005+Vlad0n20@users.noreply.github.com>
…1578) * implement admin user merge as a background task * fix test
…e) (CenterForOpenScience#11591) * implement asc sorting for admin brand tab (case insensitive) * Fix indentation in brand list template
Revert BE changes meant to fix 10042 and replace with FE changes.
…cience#11361) * Add management command to manual archive * fix test * Fix lints * Fix tests
* use GV addons caching when it's needed * fixed None issue when iterate * fixed tests
* removed ember mentions of ember in docker and readme * removed ember-related constants, flags, tests and functionality * fixed redirects to unexisting index and dashboard flask views * fixed redirects * added redirect for removed views * removed assert for duplicated redirect as it'll be handled by angular * fix imports after notification refactor * fix tests * remove edit_draft_registration_page and new_draft_registration views --------- Co-authored-by: Ihor Sokhan <isokhan@exoft.net>
…ren projects in API (CenterForOpenScience#11605) * raise permission error if user is not admin on child node * fix tests
…tus (CenterForOpenScience#11604) * indicate if the preprint is spammy with meta: {flagged_content: true} * make sure that the sitemap doesn’t include any spammy preprint. * update generate sitemap test * get base get_meta in child meta to keep all needed meta data * exclude spam content for preprints sitemap * unify server response on getting specific registry/node/preprint if it is spammy to make it possible to create info page on front end * exclude spam from Nodes and Registrations on sitemap generation * avoid errors for objects where spam may not be determined * update code * show more specific message for spammy resource on contributor access {'flagged_content': True} to render specific UI to show contributor how to get support to ham the resource * implement unittests for spammy resource contributor access * refactor code * show if resource is spammed on retrieval to all types of user * add tests * ensure that the sitemap is working correctly for spammed content * Delete api_tests/preprints/views/test_preprint_detail_new_behaviors.py remove not needed test * raise Gone for deleted not spammed preprint to keep it same as for other deleted resources * change 404 to 410 for deleted preprints in tests * change 404 to 410 for deleted preprints in tests
…orOpenScience#11614) * fixed not shared spam_data among user and his nodes/preprints * fixed case when resource is a user * handle hammy user cases * fixed old tests * creator is spammed instead of flagged when a node contains spam * fixed tests and case when suspend user directly thus must spam main node/preprint * capture notifications
* remove vulnarable packages and some web ui content * add missing changes * return project template * fix tests * remove unused packages
adlius
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-10328
Purpose
Some users with older preprints encounter an issue when
has_coi = Truebutconflict_of_interest_statement=''It may happen because of some bug on the legacy UI or we had some issues with validation COI that allowed user to bypass validation in the past on BE that was fixed after Preprint Affiliation Project but the older preprints still contain invalid data that makes it impossible to pass the current validation during creation of a new version of a preprint
Changes
Added button on a preprint admin page to fix this case