feat(ci): port status visibility and consistent component recursion#409
Open
Chaffelson wants to merge 1 commit into
Open
feat(ci): port status visibility and consistent component recursion#409Chaffelson wants to merge 1 commit into
Chaffelson wants to merge 1 commit into
Conversation
get_status now reports input/output port counts (total, running, stopped, invalid) and derives processor counts from enumeration rather than the PG aggregate, so invalid ports are no longer mis-reported as invalid processors. Adds canvas.list_invalid_ports (parallel to list_invalid_processors) and a verify_ports option to verify_config with a new port_results key. verify_config controller verification now recurses into descendant PGs (descendants=True), consistent with processor and port verification, while still excluding ancestor-inherited services. Also reworks the developer release guide into separate Patch and Full release workflows. .... Generated with [Cortex Code](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code) Co-Authored-By: Cortex Code <noreply@snowflake.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
==========================================
+ Coverage 76.84% 76.93% +0.09%
==========================================
Files 41 41
Lines 4832 4869 +37
==========================================
+ Hits 3713 3746 +33
- Misses 1119 1123 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_statusnow reports input/output port counts (total, running, stopped, invalid) and derives processor counts from enumeration rather than the PG aggregate component count — so invalid ports are no longer mis-reported as invalid processors.canvas.list_invalid_ports(parallel tolist_invalid_processors) returning ports with validation errors across a PG and its descendants.verify_configgains averify_portsoption (defaultTrue) and a newport_resultskey; ports with validation errors now fail verification.verify_configcontroller verification now recurses into descendant PGs (descendants=True), consistent with processor/port verification, while still excluding ancestor-inherited services.Motivation
Invalid ports (e.g. an output port with no outgoing connection) cause FlowFiles to queue indefinitely with no error, no bulletin, and — previously — no visibility in
get_statusorverify_config. This makes that state visible and reported consistently across component types.Behaviour change
get_statusinvalid_processors/running_processorsvalues are now processor-accurate (previously included all component types). New*_input_ports/*_output_portsfields are additive.verify_confignow fails when a controller in a descendant PG is invalid, where it previously only checked the target PG.Test plan
make test NIPYAPI_PROFILE=single-user— full suite green (port/processor/controller paths; 21 git-registry errors are unrelated, requireGH_REGISTRY_TOKEN)test_list_invalid_ports,test_verify_config_with_invalid_port,test_get_status_port_counts,test_verify_config_includes_descendant_controllersmake pre-commitclean.... Generated with Cortex Code