Skip to content

chore: unignore RUSTSEC-2026-0097 in deny.toml#6963

Merged
LesnyRumcajs merged 1 commit into
mainfrom
hm/unignore-RUSTSEC-2026-0097
Apr 23, 2026
Merged

chore: unignore RUSTSEC-2026-0097 in deny.toml#6963
LesnyRumcajs merged 1 commit into
mainfrom
hm/unignore-RUSTSEC-2026-0097

Conversation

@hanabi1224
Copy link
Copy Markdown
Contributor

@hanabi1224 hanabi1224 commented Apr 23, 2026

Summary of changes

https://github.com/ChainSafe/forest/actions/runs/24829818959/job/72675150933#step:5:13

warning[advisory-not-detected]: advisory was not encountered
  ┌─ /home/runner/work/forest/forest/deny.toml:9:4
  │
9 │   "RUSTSEC-2026-0097", # Rand is unsound with a custom logger using `rand::rng()`
  │    ━━━━━━━━━━━━━━━━━ no crate matched advisory criteria
advisories ok

CI run against PR branch: https://github.com/ChainSafe/forest/actions/runs/24830036706/job/72675890764

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

Walkthrough

The pull request removes the RustSec advisory RUSTSEC-2026-0097 from the deny.toml configuration file's ignore list, making that advisory no longer suppressed by the project's dependency checking configuration.

Changes

Cohort / File(s) Summary
RustSec Advisory Ignore List
deny.toml
Removed RUSTSEC-2026-0097 from the advisories ignore list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • akaladarshi
  • LesnyRumcajs
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: unignore RUSTSEC-2026-0097 in deny.toml' directly and clearly describes the main change: removing an advisory from the ignore list in deny.toml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hm/unignore-RUSTSEC-2026-0097
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch hm/unignore-RUSTSEC-2026-0097

Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 marked this pull request as ready for review April 23, 2026 10:23
@hanabi1224 hanabi1224 requested a review from a team as a code owner April 23, 2026 10:23
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and akaladarshi and removed request for a team April 23, 2026 10:23
@LesnyRumcajs LesnyRumcajs enabled auto-merge April 23, 2026 10:46
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Apr 23, 2026
Merged via the queue into main with commit 9eca031 Apr 23, 2026
38 of 41 checks passed
@LesnyRumcajs LesnyRumcajs deleted the hm/unignore-RUSTSEC-2026-0097 branch April 23, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants