feat: Add task search bar for real-time task filtering.#993
Open
Rohith0750 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a task search input that filters tasks by title or notes alongside the existing label filter.
Changes:
- Introduces a
searchQuerystate variable and input handler that re-renders tasks on change. - Updates
renderTasksto apply the search filter in combination with the label filter. - Adds a search
<input>element in the topbar and adjusts the label-filter styling for layout.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| js/app.js | Adds search query state, input listener, and search filtering logic in renderTasks. |
| index.html | Adds the search input field and shifts margin styling on the label filter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <div class="topbar"> | ||
| <div class="topbar-title">April 2026</div> | ||
| <select id="label-filter" style="margin-left:auto; margin-right: 12px; padding: 6px; border-radius: 6px; border: 1px solid var(--color-border-secondary); background: var(--color-background-primary); color: var(--color-text-primary); outline: none; cursor: pointer;"> | ||
| <input type="text" id="task-search" placeholder="Search tasks..." style="margin-left:auto; margin-right: 12px; padding: 6px 12px; border-radius: 6px; border: 1px solid var(--color-border-secondary); background: var(--color-background-primary); color: var(--color-text-primary); outline: none; width: 180px;"> |
Comment on lines
+117
to
+118
| <input type="text" id="task-search" placeholder="Search tasks..." style="margin-left:auto; margin-right: 12px; padding: 6px 12px; border-radius: 6px; border: 1px solid var(--color-border-secondary); background: var(--color-background-primary); color: var(--color-text-primary); outline: none; width: 180px;"> | ||
| <select id="label-filter" style="margin-right: 12px; padding: 6px; border-radius: 6px; border: 1px solid var(--color-border-secondary); background: var(--color-background-primary); color: var(--color-text-primary); outline: none; cursor: pointer;"> |
Author
|
Hi @Charushi06, I have completed the implementation and submitted a PR for this issue. PR: #988 Looking forward to your review. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #988
Summary
This pull request adds a real-time task search bar next to the label-filter dropdown in the main dashboard. Students can now filter their active or archived tasks by typing keywords that match task titles or notes.
Changes Made
#task-searchinindex.html, positioned inline with the existing top-bar controls.searchQuerystate and a text input listener injs/app.jsto handle real-time search input.renderTasks()function injs/app.jsto dynamically filter tasks based on the current search query.Testing
npm start.npm test.Screenshots
Before
After