fix: handle day after tomorrow before tomorrow#995
Open
suhanimaurya05 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #939
Summary
Fixed incorrect parsing of the phrase "day after tomorrow" in the client-side NLP date extractor. The extractor was matching "tomorrow" before checking the longer phrase, causing both expressions to resolve to the same date.
Changes Made
js/utils/nlpDateExtractor.js.day after tomorrowbeforetomorrow.day after tomorrowresolves to two days from the current date.Testing
Tested locally by parsing:
Submit math homework tomorrowSubmit math homework day after tomorrowVerified that:
tomorrowresolves to current date + 1 day.day after tomorrowresolves to current date + 2 days.Screenshots
N/A (No UI changes)
Checklist