20260722 generic clvm - #532
Draft
prozacchiwawa wants to merge 9 commits into
Draft
Conversation
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4eb95ac. Configure here.
prozacchiwawa
marked this pull request as draft
July 25, 2026 00:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
High Risk
Large, cross-cutting refactor of the classic compiler, optimizer, and module loader—behavior-sensitive paths where subtle generic/import-export mistakes could change compilation or diagnostics.
Overview
Introduces
ClassicAllocatorinabstraction.rsas the shared interface for classic CLVM tooling: abstractNodePtr,ASExp,import/exporttoclvm_rs::Allocator, andClError(Srcloc, EvalErr)on list/atom construction and traversal errors.Stage-2 pipeline (
compile,optimize,module,helpers,inline,reader,defaults) and shared utilities (sexp,pattern_match,debug,operators) are rewritten to takeA: ClassicAllocatorinstead of&mut Allocatordirectly. Node handles are passed by reference;allocator.locis supplied when building atoms/pairs.TRunProgramstill runs on the raw allocator viaexporton inputs andimporton results.do_com_prog/do_optimizenow returnResult<NodePtr, ClError>(noReduction/Responsewrapper at that layer).FunctionExtraInfoand related debug/symbol dump paths are generic over the allocator type.clvm_rs::AllocatorimplementsClassicAllocatoras identity import/export with a default*clvm*source location.Reviewed by Cursor Bugbot for commit a50e981. Bugbot is set up for automated code reviews on this repo. Configure here.