Use fail-closed WASM random backend - #533
Draft
prozacchiwawa wants to merge 2 commits into
Draft
Conversation
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getrandom_backend="unsupported"for the WASM buildgetrandom0.4/JavaScript-binding dependencies introduced by the earlier fixCause
The previous
custombackend selection had no implementation, leaving an unresolved WASMenvimport that wasm-bindgen emitted asrequire("env").Strategy
The
unsupportedbackend is fail-closed: it introduces no JavaScript randomness interface and returns an explicit error if the WASM surface requests entropy. This avoids both an unresolved custom import and an insecure deterministic fallback.The existing transitive dependency graph still contains
getrandom0.3 and 0.4 throughclvmr's crypto dependencies, but neither receives thewasm_jsfeature and the package contains no JavaScript crypto bindings.Validation
node wasm/tests/index.jspassedgetRandomValues,crypto, orrequire("env")binding