Repository navigation
Read and replace a network as raw JSON - #24
Merged
Merged
Conversation
UnifiNetwork models about 12 of a live network's ~63 fields and
rest/networkconf/{id} is a full replacement, so a typed update would reset
the rest. Add ListNetworksRawAsync, GetNetworkRawAsync (exactly one row or
throw) and ReplaceNetworkRawAsync (body sent verbatim) over JsonObject, and
NetworkDhcpDns to read or change only dhcpd_dns_enabled and dhcpd_dns_1..4.
There is deliberately no UpdateNetworkAsync(UnifiNetwork).
UnifiLegacySession gains an internal handler seam so unit tests can assert
the bytes on the wire.
6 tasks
Creates a scratch network, writes DHCP DNS through NetworkDhcpDns.With, asserts only the DNS keys moved, restores the saved object and asserts every key matches its JSON text, and checks no other network changed. Skips without UNIFI_LEGACY_BASE_URL + UNIFI_USERNAME + UNIFI_PASSWORD and refuses any host but localhost / 127.0.0.1 / ::1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets a caller change one network setting without dropping the rest:
UnifiNetworkmodels about 12 of a live network's 63 fields, so a typed update would reset the others.What changed
ListNetworksRawAsync,GetNetworkRawAsync(exactly one row or throw),ReplaceNetworkRawAsync(body sent verbatim), all overJsonObjectNetworkDhcpDns.Read/With:Withchanges onlydhcpd_dns_enabledanddhcpd_dns_1..4and never mutates its inputUpdateNetworkAsync(UnifiNetwork), on purposeUnifiLegacySessionso tests can assert the bytes sent; public API unchangedVerification
dotnet test: 59 passed, 0 failed, 10 skipped (the existing live-test gate). Not run against a live controller; a read-only live test is included.Closes #23
Spec: Chrison-Homelab/Homelab#736 (the Consumer DHCP DNS spec)