fix: include the tab id in get_tab_id's text response#2381
Merged
OrKoN merged 1 commit intoJul 20, 2026
Conversation
thomasbachem
changed the title
get_tab_id's text response
`get_tab_id` gates on `--experimentalInteropTools`, but its result only went into `structuredContent`, which is dropped unless `--experimentalStructuredContent` is also set – with interop alone the tool always returned an empty text response. Append a `Tab ID: <id>` line to the text response, keeping `structuredContent.tabId` as-is.
thomasbachem
force-pushed
the
fix/get-tab-id-text-output
branch
from
July 16, 2026 20:06
417555a to
ea51275
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #2366:
get_tab_idgates on--experimentalInteropTools, but its result only went intostructuredContent, which is dropped unless--experimentalStructuredContentis also set – so with interop alone the tool always returned an empty text response.This appends a
Tab ID: <id>line to the text response and keepsstructuredContent.tabIdas-is –key: valueso it stays trivially parseable.Testing
The existing
returns the tab idtest asserted emptyresponseLines, which pinned the old behavior – now it asserts theTab ID:line. Verified end-to-end over stdio with--experimentalInteropToolsalone: the text response isTab ID: <id>where it was""before.