Add paywall indicator#141
Open
pnijjar wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Why the heck is the PR acceptance template over 200 lines long? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Add a lock indicator to media behind a paywall. This includes a tooltip but does not show up on text-based browsers.
Related Issue(s): Closes #140
Type of Change
Community Impact
Who benefits from this change?
People who are irritated by clicking paywalled links.
Testing & Quality Assurance
Manual Testing
Automated Testing
Accessibility Testing
Civic Tech Considerations
Privacy & Security
Inclusivity & Accessibility
Community Engagement
DVF Assessment Impact
How does this change affect our project's DVF scorecard?
Community Partner (1-5): [Current score] → [New score if changed]
Talent & Team (1-5): [Current score] → [New score if changed]
Technically Exciting (1-5): [Current score] → [New score if changed]
Civic Exciting (1-5): [Current score] → [New score if changed]
Demo Day Readiness
Season Timeline Alignment
Target Week: [Week X of 12-week season]
Code Quality Checklist
Documentation & Knowledge Sharing
Deployment & Rollout
Community Review
Additional reviewers needed:
Community testing:
Visual Changes (if applicable)
Screenshots/Videos
[Add screenshots, GIFs, or videos to help explain your changes]
Before/After Comparison
[Show the improvement or change visually]
Performance Impact (if applicable)
Performance measurements:
[Include before/after metrics if relevant]
Breaking Changes (if applicable)
[Describe any breaking changes and migration path for users]
Additional Notes
[Any additional information that reviewers should know]
Related Work
Follow-up Work
For Reviewers: