Skip to content

[TP-2072] Fix stg SDH url - part 2 #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mimarcel merged 1 commit into from
May 22, 2026
+3 −0
Merged

[TP-2072] Fix stg SDH url - part 2 #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@
if secure_hosting_url == "https://data-dev-internal.clarifai.com":
if url.startswith("https://data-dev.clarifai.com"):
return url.replace("https://data-dev.clarifai.com", secure_hosting_url)
if secure_hosting_url == "https://data-staging-internal.clarifai.com":
if url.startswith("https://data-staging.clarifai.com"):

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization High test

The string
https://data-staging.clarifai.com
Loading
may be at an arbitrary position in the sanitized URL.
Comment thread
mimarcel marked this conversation as resolved.
Dismissed
return url.replace("https://data-staging.clarifai.com", secure_hosting_url)
if secure_hosting_url != orig_secure_hosting_url and url.startswith(orig_secure_hosting_url):
return url.replace(orig_secure_hosting_url, secure_hosting_url)
return url
Expand Down
Loading