feat: extend BetaBadge with link and galaxy tracking#42
Open
mintlify[bot] wants to merge 1 commit into
Open
Conversation
3 tasks
Contributor
Author
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports ClickHouse/clickhouse-docs#6260 — extends
BetaBadgeto supportlink,galaxyTrack, andgalaxyEventprops so it renders as a tracked anchor (matching the existingPrivatePreviewBadgepattern).Changes
snippets/components/BetaBadge/BetaBadge.jsx— accept{ link, galaxyTrack, galaxyEvent }; whenlinkis set, render as<a target="_blank">with optionalgalaxyOnClick(galaxyEvent)handler. Default no-prop render unchanged.snippets/components/Badges/BetaBadge.jsx— same change applied to the duplicate component for parity.Context
Upstream uses the Docusaurus
src/lib/galaxy/galaxyhelper; the Mintlify port wires through the existing shim at/snippets/lib/galaxy.jsx(galaxyOnClick).Notes / ambiguity
BetaBadge.jsxcopies (components/BetaBadge/andcomponents/Badges/). Only the former is referenced by content today; both were updated for consistency. Worth consolidating in a follow-up.styles.betaBadge); the Mintlify versions use the globalbetaBadgeclass — preserved as-is.<Icon />Beta(no "feature." text or "Learn more" link), mirroring the upstream behavior.PrivatePreviewBadgeand update existing instances — not in scope here.