Skip to content

Don't assume float32 input for JPEG2000 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
treigerm merged 2 commits into from
Nov 26, 2025
Merged

Don't assume float32 input for JPEG2000 #58

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a668f6f
Don't assume float32 input for JPEG2000
treigerm Nov 21, 2025
a5ca3f7
Cleaner way to get dtype name
treigerm Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/climatebenchpress/compressor/compressors/jpeg2000.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,12 @@ def abs_bound_codec(
*,
data_min=None,
data_max=None,
dtype=None,
**kwargs,
):
assert data_min is not None, "data_min must be provided"
assert data_max is not None, "data_max must be provided"
assert dtype is not None, "dtype must be provided"

max_pixel_val = 2**25 - 1 # maximum pixel value for our integer encoding.

Expand All @@ -56,7 +58,7 @@ def abs_bound_codec(
# increase precision for better rounding during linear quantization
numcodecs.astype.AsType(
encode_dtype="float64",
decode_dtype="float32",
decode_dtype=str(dtype),
Comment thread
treigerm marked this conversation as resolved.
Outdated
),
# remap from [min, max] to [0, max_pixel_val]
numcodecs_wasm_fixed_offset_scale.FixedOffsetScale(
Expand Down