Fix missing error handling for IPC::Open3 in ipc_open3 subroutine#2078
Open
prjanitor wants to merge 1 commit intoClinical-Genomics:developfrom
Open
Conversation
Add validation to check if open3() succeeds before attempting to read from filehandles. If open3() fails, $writer, $reader, and $error will be undefined, causing silent failures or crashes when reading from undefined filehandles. Closes Clinical-Genomics#431
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
ipc_open3subroutine inlib/MIP/System_call.pmdid not check ifopen3()succeeds before attempting to read from filehandles. Ifopen3()fails,$writer,$reader, and$errorwill be undefined, causing silent failures or crashes when reading from undefined filehandles.Changes
open3()call to check if it succeededopen3()fails (returnsundef), the subroutine now croaks with an informative error message including the command string and the system errorTesting
The fix ensures that:
open3()fails, an error is raised immediately with contextopen3()succeededCloses #431
This PR was generated by PRJanitor — an automated tool that finds and fixes small bugs in open-source projects.
We respect your contribution guidelines — if your project doesn't accept bot PRs, we won't send more. You can also add a
.github/prjanitor.ymlfile withenabled: falseto opt out explicitly.