Skip to content

Added Memento pattern #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cotel wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added Memento pattern #40

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6aaffec
Added Memento pattern
Cotel Apr 24, 2017
b74db35
Fixing tests and improving CareTaker
Cotel May 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/main/kotlin/oop/Memento/CareTaker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
package oop.Memento

class CareTaker<T> {
val mementoList = mutableListOf<Memento<T>>()
private val mementoList = mutableListOf<Memento<T>>()

fun addMemento(memento: Memento<T>) {
mementoList.add(memento)
}

fun getMemento(index: Int) : Memento<T>? = mementoList[index]
}
Copy link
Copy Markdown
Member Author

@Cotel Cotel May 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really the best way to do this in Kotlin? I see little sense in wrapping a mutable list 🤔

6 changes: 3 additions & 3 deletions src/test/kotlin/oop/Memento/MementoTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class MementoTest {

val memento = originator.saveToMemento()

assert.that(memento.state, `is`(memento.state))
assert.that(originator.state, `is`(memento.state))
}

@Test
Expand All @@ -35,9 +35,9 @@ class MementoTest {
val originator = Originator(listOf(1,2,3))
val memento = originator.saveToMemento()

careTaker.mementoList.add(memento)
careTaker.addMemento(memento)

assert.that(careTaker.mementoList[0], `is`(memento))
assert.that(careTaker.getMemento(0)!!, `is`(memento))
}

}