-
Notifications
You must be signed in to change notification settings - Fork 1
New observer implementation #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package oop.Observer2 | ||
|
|
||
| class CategoryObserver : Observer<String> { | ||
| override val list = mutableListOf<Player>() | ||
|
|
||
| override fun onChange(newValue: String){ | ||
| list.forEachIndexed { _, player -> | ||
| player.notify(newValue) | ||
| } | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package oop.Observer2 | ||
|
|
||
| interface Observer<T>{ | ||
| val list: MutableList<Player> | ||
| fun onChange(newValue: T) | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package oop.Observer2 | ||
|
|
||
|
|
||
| data class Player (val name: String, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Player is the observer. The Roulette is observable. |
||
| var currentCategory: String = "history"){ | ||
| fun notify(newCategory: String){ | ||
| println("$name: category changed to $newCategory") | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package oop.Observer2 | ||
|
|
||
| import kotlin.properties.Delegates | ||
|
|
||
| class Roulette{ | ||
|
|
||
| var observer: CategoryObserver? = null | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is no need to create a separated object in this case. I think it is more natural if Players are observing the Roulette directly 👍 |
||
|
|
||
| var newCategory: String by Delegates.observable("") { _, _, new -> | ||
| observer?.onChange(new) | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why must an Observer have a list of Players? This is an unnecessary coupling 😅