Skip to content

Enhance cashflow with frequency and projection start date#395

Merged
prooflesben merged 15 commits intomainfrom
389-dev-change-cost-type-and-frontend-for-cost
Apr 12, 2026
Merged

Enhance cashflow with frequency and projection start date#395
prooflesben merged 15 commits intomainfrom
389-dev-change-cost-type-and-frontend-for-cost

Conversation

@janekamata
Copy link
Copy Markdown
Contributor

@janekamata janekamata commented Apr 5, 2026

ℹ️ Issue

Closes #389

📝 Description

Comprehensively added frequency field to cost and start date to default values

Briefly list the changes made to the code:

  1. Created new Frequency enum for cashflow cost
  2. Updated cost and default types in front/back end
  3. Updated backend tests and routes to include new fields
  4. Updated processCashflow functions with new fields
  5. Added sorting to local cashflow item lists to fix bug where editing line item reorders them in unclear manner
  6. Combined CashEditCost and CashAddCost into one component
  7. Added date to cash position component
  8. Updated cost card text and added scrolling to line item lists
  9. Miscellaneous styling fixes on GrantPage, GrantView, and cashflow

✔️ Verification

What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.

Tested adding/editing

Provide screenshots of any new components, styling changes, or pages.
image
image
image

Test Changes

If your new feature required some test to be changed or added to fit the new functionality or changes please document these changes here.

🏕️ (Optional) Future Work / Notes

Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!

During stand-up we agreed on the three types of one-time, annual, and annual distributed monthly. However, I wasn't sure how to communicate the last one in a way that made sense to the user, so I currently have it as monthly. During the client meeting, please check if this is needed and also how it should be displayed (both in edit/add and on the card text) so that it is intuitive

I added scrolling to the line item lists but not sure if it's better or not so if we could have some discussion around that as well that would be good. Maybe during next standup

@janekamata janekamata self-assigned this Apr 5, 2026
@janekamata janekamata linked an issue Apr 5, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Collaborator

@prooflesben prooflesben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry to say this but Hessan said the 3 month case is valid and he wants a custom frequency. I would change the frequency from an enum to just the number of months the frequency is since it can be from 1 month to 36 months or 0 months(Could be treated as one time). I would still have the frontend have the dropdown with the options but add a custom option where the user can input how many months they want from 1 to 12 months. (There is a tiny chance we could want things over 12 months like every 18 months but if that case comes up in the future this model of frequency should be able to handle that but we aren;t going to handle it right now in interest of time)

@prooflesben prooflesben merged commit 2202e50 into main Apr 12, 2026
1 check passed
janekamata added a commit that referenced this pull request Apr 12, 2026
commit 2202e50
Merge: 08a77c8 c70cae6
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date:   Sun Apr 12 16:36:14 2026 -0400

    Merge pull request #395 from Code-4-Community/389-dev-change-cost-type-and-frontend-for-cost

    Enhance cashflow with frequency and projection start date

commit c70cae6
Author: prooflesben <prooflesben@gmail.com>
Date:   Sun Apr 12 16:34:01 2026 -0400

    fixed error

commit 99417b3
Merge: fece561 08a77c8
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date:   Sun Apr 12 15:56:31 2026 -0400

    Merge branch 'main' into 389-dev-change-cost-type-and-frontend-for-cost

commit 08a77c8
Merge: 1da382c c2b410b
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date:   Sun Apr 12 15:19:03 2026 -0400

    Merge pull request #387 from Code-4-Community/383-dev---ensure-edit-revenue-works

    edit revenue

commit fece561
Merge: 27dcfa8 1da382c
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date:   Sun Apr 12 14:00:22 2026 -0400

    Merge branch 'main' into 389-dev-change-cost-type-and-frontend-for-cost

commit 27dcfa8
Author: Jane Kamata <janekamata8@gmail.com>
Date:   Sun Apr 5 02:29:05 2026 -0400

    Updating start date default for cost

commit 2cf186e
Author: Jane Kamata <janekamata8@gmail.com>
Date:   Sun Apr 5 02:18:55 2026 -0400

    Styling changes

commit 3a7ce4b
Author: Jane Kamata <janekamata8@gmail.com>
Date:   Sun Apr 5 02:02:47 2026 -0400

    Added alpha sort to line items, added scrolling

commit 60c9145
Author: Jane Kamata <janekamata8@gmail.com>
Date:   Sun Apr 5 01:53:14 2026 -0400

    Updating frequency type

commit 39479c1
Author: Jane Kamata <janekamata8@gmail.com>
Date:   Sun Apr 5 01:28:32 2026 -0400

    Adding success message animation

commit c38b79c
Author: Jane Kamata <janekamata8@gmail.com>
Date:   Sun Apr 5 00:57:26 2026 -0400

    Updating service check

commit b5c2c2f
Author: Jane Kamata <janekamata8@gmail.com>
Date:   Sun Apr 5 00:45:55 2026 -0400

    Updating default values tests

commit 35fb779
Author: Jane Kamata <janekamata8@gmail.com>
Date:   Sun Apr 5 00:37:31 2026 -0400

    Updating tests

commit 488b030
Author: Jane Kamata <janekamata8@gmail.com>
Date:   Sat Apr 4 23:52:47 2026 -0400

    Styling fixes

commit 6f96c7d
Author: Jane Kamata <janekamata8@gmail.com>
Date:   Sat Apr 4 23:42:00 2026 -0400

    Adding start date

commit 8c59d00
Author: Jane Kamata <janekamata8@gmail.com>
Date:   Sat Apr 4 22:43:22 2026 -0400

    Updating add/edit cost

commit dea1ff7
Author: Jane Kamata <janekamata8@gmail.com>
Date:   Sat Apr 4 18:58:06 2026 -0400

    Updating types and checks

commit c2b410b
Author: adityapat24 <appathak46@gmail.com>
Date:   Thu Apr 2 16:18:58 2026 -0400

    edit revenue
@janekamata janekamata deleted the 389-dev-change-cost-type-and-frontend-for-cost branch April 17, 2026 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEV Change Cost type and frontend for cost

2 participants