Repository navigation
feat(vmnet): add batched packet I/O - #289
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Interface.ReadPacketsandInterface.WritePacketsfor Ethernet frame batches. Callers own the buffers and can reuse them between reads. Native calls respect vmnet's packet and byte limits, and write errors return the number of frames confirmed sent.Use batched reads in
vmnetsockand combine Stream frames withnet.Buffers. Datagram frame boundaries and theAdapter.Dup/Adapter.Closeownership contract stay unchanged. Includes GoDoc examples and tests for buffer reuse, burst delivery, cancellation, and shutdown.This adds the packet batching support discussed in #205.