Repository navigation
feat(vmnet): support Virtio packet headers - #290
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
WithInterfaceVirtioHeaderfor applications that exchange packets with a 12-byte Virtio network header.MaxPacketSizeincludes the header, so single-packet I/O, batch I/O, andvmnetsockuse the required buffer size. Enabling checksum offload at the same time returns an error before the interface starts.This covers the native Virtio-header option from #205. The mode is opt-in and requires a peer that understands the header and its offload metadata. QEMU's stream/socket backends, VZ file-handle attachments, and krunkit's current Unix datagram backend expect plain Ethernet frames. They need separate support before they can use this mode.
vmnetsockforwards packet bytes unchanged and keeps its existingDupandClosebehavior.