fix auth problems permission boundaries#489
Open
amahuli03 wants to merge 4 commits intoCodeForPhilly:developfrom
Open
fix auth problems permission boundaries#489amahuli03 wants to merge 4 commits intoCodeForPhilly:developfrom
amahuli03 wants to merge 4 commits intoCodeForPhilly:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the infrastructure to separate admin access from regular authenticated access. Currently, since the only authenticated users are admin, we're treating any "logged in" users as admin.
changes:
permissions.IsSuperUserpermissions.IsAuthenticatedAUTHENTICATED_SUCCESS) was hardcodingisSuperuser: truewithout looking at the tokenLOGIN_SUCCESShandles the tokenAdminRoutecomponent separates admin pages from pages that just require any authenticated userCORS_ALLOWED_ORIGINS=http://localhost:3000todev.env.exampleRelated Issue
Closes #484
Part of #483
Manual Tests
Admin permissions boundaries still work, I verified this by trying to access admin endpoints as an unauthenticated user as well as as an admin user.
Route protection works--trying to access admin pages as an unauthenticated user redirects to the login page as it should
Notes
If you have an existing
dev.env, you'll need to manually addCORS_ALLOWED_ORIGINS=http://localhost:3000to it.Also, the CORS settings will have to be updated on the prod and sandbox env configurations once this deploys.
TODO: figure out exactly what this needs in sandbox and prod