Merge pull request #119 from CodeGov-org/nathan/allow-changing-commit-sha

feat: allow changing commit sha on review form

Author: nathanosdev

.eslintrc.js

@@ -53,6 +53,9 @@ module.exports = {
         ecmaVersion: 'latest',
         project: ['./src/{docs,marketing}/tsconfig.json'],
       },
+      rules: {
+        '@typescript-eslint/triple-slash-reference': 0,
+      },
     },
     {
       files: ['src/frontend/**/*.ts'],

src/backend/api/backend.did

@@ -230,7 +230,6 @@ type ProposalReview = record {
   last_updated_at : opt text;
   status : ProposalReviewStatus;
   summary : opt text;
-  review_duration_mins : opt nat16;
   build_reproduced : opt bool;
   images_paths : vec text;
   proposal_review_commits : vec ProposalReviewCommitWithId;
@@ -245,7 +244,6 @@ type ProposalReviewWithId = record {
 type CreateProposalReviewRequest = record {
   proposal_id : text;
   summary : opt text;
-  review_duration_mins : opt nat16;
   build_reproduced : opt bool;
   vote : opt ProposalVote;
 };
@@ -259,7 +257,6 @@ type UpdateProposalReviewRequest = record {
   proposal_id : text;
   status : opt ProposalReviewStatus;
   summary : opt text;
-  review_duration_mins : opt nat16;
   build_reproduced : opt bool;
   vote : opt ProposalVote;
 };
@@ -296,7 +293,6 @@ type ReviewCommitState = variant {
   reviewed : record {
     matches_description : opt bool;
     comment : opt text;
-    highlights : vec text;
   };
   not_reviewed;
 };

src/backend/api/src/proposal_review.rs

@@ -28,7 +28,6 @@ pub struct ProposalReview {
     pub last_updated_at: Option<String>,
     pub status: ProposalReviewStatus,
     pub summary: Option<String>,
-    pub review_duration_mins: Option<u16>,
     pub build_reproduced: Option<bool>,
     pub images_paths: Vec<String>,
     pub proposal_review_commits: Vec<ProposalReviewCommitWithId>,
@@ -45,7 +44,6 @@ pub struct ProposalReviewWithId {
 pub struct CreateProposalReviewRequest {
     pub proposal_id: String,
     pub summary: Option<String>,
-    pub review_duration_mins: Option<u16>,
     pub build_reproduced: Option<bool>,
     pub vote: Option<ProposalVote>,
 }
@@ -57,7 +55,6 @@ pub struct UpdateProposalReviewRequest {
     pub proposal_id: String,
     pub status: Option<ProposalReviewStatus>,
     pub summary: Option<String>,
-    pub review_duration_mins: Option<u16>,
     pub build_reproduced: Option<bool>,
     pub vote: Option<ProposalVote>,
 }

src/backend/api/src/proposal_review_commit.rs

@@ -6,7 +6,6 @@ pub enum ReviewCommitState {
     Reviewed {
         matches_description: Option<bool>,
         comment: Option<String>,
-        highlights: Vec<String>,
     },
     #[serde(rename = "not_reviewed")]
     NotReviewed,

src/backend/impl/src/controllers/proposal_review_commit_controller.rs

@@ -142,7 +142,6 @@ mod tests {
             state: backend_api::ReviewCommitState::Reviewed {
                 matches_description: Some(true),
                 comment: Some("comment".to_string()),
-                highlights: vec![],
             },
         };
         let response = CreateProposalReviewCommitResponse {
@@ -184,7 +183,6 @@ mod tests {
             state: backend_api::ReviewCommitState::Reviewed {
                 matches_description: Some(true),
                 comment: Some("comment".to_string()),
-                highlights: vec![],
             },
         };
         let error = ApiError::permission_denied(&format!(
@@ -221,7 +219,6 @@ mod tests {
             state: backend_api::ReviewCommitState::Reviewed {
                 matches_description: Some(true),
                 comment: Some("comment".to_string()),
-                highlights: vec![],
             },
         };
 
@@ -255,7 +252,6 @@ mod tests {
             state: backend_api::ReviewCommitState::Reviewed {
                 matches_description: Some(true),
                 comment: Some("comment".to_string()),
-                highlights: vec![],
             },
         };
         let error = ApiError::permission_denied(&format!(

src/backend/impl/src/controllers/proposal_review_controller.rs

@@ -254,7 +254,6 @@ mod tests {
         let request = CreateProposalReviewRequest {
             proposal_id: "proposal_id".to_string(),
             summary: Some("summary".to_string()),
-            review_duration_mins: Some(10),
             build_reproduced: Some(true),
             vote: Some(ProposalVote::Yes),
         };
@@ -297,7 +296,6 @@ mod tests {
         let request = CreateProposalReviewRequest {
             proposal_id: "proposal_id".to_string(),
             summary: Some("summary".to_string()),
-            review_duration_mins: Some(10),
             build_reproduced: Some(true),
             vote: Some(ProposalVote::No),
         };
@@ -338,7 +336,6 @@ mod tests {
             proposal_id: fixtures::proposal_id().to_string(),
             status: None,
             summary: Some("summary".to_string()),
-            review_duration_mins: Some(10),
             build_reproduced: Some(true),
             vote: Some(ProposalVote::Yes),
         };
@@ -374,7 +371,6 @@ mod tests {
             proposal_id: fixtures::proposal_id().to_string(),
             status: None,
             summary: Some("summary".to_string()),
-            review_duration_mins: Some(10),
             build_reproduced: Some(true),
             vote: None,
         };

src/backend/impl/src/fixtures/id.rs

@@ -14,7 +14,7 @@ pub fn principal_b() -> Principal {
 
 #[fixture]
 pub fn principal_c() -> Principal {
-    Principal::from_slice(&[1])
+    Principal::from_slice(&[2])
 }
 
 #[fixture]

src/backend/impl/src/fixtures/proposal_review.rs

@@ -13,7 +13,6 @@ pub fn proposal_review_draft() -> ProposalReview {
         last_updated_at: None,
         status: ProposalReviewStatus::Draft,
         summary: Some("Proposal review summary".to_string()),
-        review_duration_mins: Some(60),
         build_reproduced: Some(true),
         images_ids: vec![],
         vote: ProposalVote::Unspecified,
@@ -29,7 +28,6 @@ pub fn proposal_review_published() -> ProposalReview {
         last_updated_at: None,
         status: ProposalReviewStatus::Published,
         summary: Some("Proposal review summary".to_string()),
-        review_duration_mins: Some(60),
         build_reproduced: Some(true),
         images_ids: vec![uuid()],
         vote: ProposalVote::Yes,

src/backend/impl/src/fixtures/proposal_review_commit.rs

@@ -15,7 +15,6 @@ pub fn proposal_review_commit_reviewed() -> ProposalReviewCommit {
         state: ReviewCommitState::Reviewed(ReviewedCommitState {
             matches_description: Some(true),
             comment: Some("Review commit comment".to_string()),
-            highlights: vec![],
         }),
     }
 }

src/backend/impl/src/mappings/proposal_review.rs

@@ -52,7 +52,6 @@ impl From<ProposalReview> for backend_api::ProposalReview {
             last_updated_at: proposal_review.last_updated_at.map(|dt| dt.to_string()),
             status: proposal_review.status.into(),
             summary: proposal_review.summary,
-            review_duration_mins: proposal_review.review_duration_mins,
             build_reproduced: proposal_review.build_reproduced,
             images_paths: vec![],
             proposal_review_commits: vec![],