feat: toggle strict null parent root nodes#215
Merged
Conversation
Owner
|
Thanks for the work on this! I think its a good solution for this version and like you said maybe in a major version we can set it as default? |
Contributor
Author
|
Indeed, it would be as simple as adding the helper method call to the |
CodeWithDennis
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #212, here is a draft of my suggestion.
By using the
strictNullParentRootNodes()configuration method, thebuildTree()method will not turn orphaned child nodes into root nodes. AnhasStrictNullParentRootNodes()helper has been added to this end.Needs documentation update.
Consider calling the configuration method by default in
relationship()on a major version change.