Birmingham | 26-ITP-Jan | Tasleem Adedokun | Sprint 3 | Alarm clock by tasleemadedokun · Pull Request #1093 · CodeYourFuture/Module-Data-Groups

tasleemadedokun · 2026-03-25T06:26:30Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Brief:
I have done the alarm coursework, and I have also done regular commits to this coursework.

…est pass the use faketimer.

magarpratik

Really good effort! 👍

I've added a few comments. Could you please review them?

magarpratik · 2026-04-03T20:05:54Z

Sprint-3/alarmclock/readme.md

@@ -1,4 +1,4 @@
-# Make an Alarm Clock
+#Make an Alarm Clock


Was this intended? You can test the markdown here.

Was this intended? You can test the markdown here.

no it wasn't intended fixed.

magarpratik · 2026-04-03T20:09:16Z

Sprint-3/alarmclock/alarmclock.js

+      if (window.JEST_WORKER_ID){
+      flashInterval = setInterval(() => {
+        document.body.style.backgroundColor =
+          document.body.style.backgroundColor === "green" ? "white" : "green";
+      }, 500);


I tested the work locally and the background colour is not changing when the timer reaches 00:00. Could you look into it?

I tested the work locally and the background colour is not changing when the timer reaches 00:00. Could you look into it?

worked on it already thanks.

Nice, the background is flashing now! Great job on completing the stretch task! 🎉

magarpratik · 2026-04-03T20:17:41Z

Sprint-3/alarmclock/alarmclock.js

+  function updateDisplay() {
+    const minutes = Math.floor(timeRemaining / 60);
+    const seconds = timeRemaining % 60;
+
+    const mm = String(minutes).padStart(2, "0");
+    const ss = String(seconds).padStart(2, "0");
+
+    display.textContent = `Time Remaining: ${mm}:${ss}`;
+  }


This logic looks good. 👍

This logic looks good. 👍

Thank you very much.

magarpratik · 2026-04-03T20:21:35Z

Sprint-3/alarmclock/alarmclock.js

+     // Decrement only if above 0
+    timeRemaining--;
+    updateDisplay();


When testing, the timer reaches stops at -1:-1 rather than 00:00. Could you look into it?

When testing, the timer reaches stops at -1:-1 rather than 00:00. Could you look into it?

I think it should be fine now.

Thank you very much for your time.

Working as expected now 👍

…is click light stop flashing.

magarpratik

Great work, app works as expected! 👍

Well done on completing the stretch task! 👏

magarpratik · 2026-04-04T10:48:40Z

Sprint-3/alarmclock/alarmclock.js

+  interval = setInterval(() => {
+    if (timeRemaining <= 0) {
+      clearInterval(interval);
+      timeRemaining = 0;


Is this needed?

tasleemadedokun added 5 commits March 24, 2026 08:26

Change title to alarm clock app.

9e994c5

Changes

2adcc6f

Implement the js function for the alarm clock.

3161e3a

Update my code so the alarm clock passes test for input like "119" etc.

942d94d

Adjust the code to assign backgroup flashing color also enable jest t…

f269468

…est pass the use faketimer.

tasleemadedokun added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Mar 25, 2026

magarpratik added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 3, 2026

magarpratik suggested changes Apr 3, 2026

View reviewed changes

magarpratik added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 3, 2026

tasleemadedokun added 3 commits April 4, 2026 06:43

Give a space in line 1 of the readme.md after the hash tag.

f0641bb

Add the new function to effect the flashing and when the stop button …

4a8d0b2

…is click light stop flashing.

Enhance new change.

5a8b6dd

tasleemadedokun added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 4, 2026

tasleemadedokun requested a review from magarpratik April 4, 2026 06:38

magarpratik reviewed Apr 4, 2026

View reviewed changes

magarpratik added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 4, 2026

Uh oh!

Conversation

tasleemadedokun commented Mar 25, 2026

Learners, PR Template

Changelist

Uh oh!

magarpratik left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

magarpratik left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants