GLASGOW | Jan-26-ITP | Prakash Dcosta | Sprint 3 | Quote Generator

[dcostaprakash]

Changelist
I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide
my coursework

[Luro91]

How could you make it more clear what HTML elements are nested inside the new divs?

[dcostaprakash]

Got it. I can add comments and i can make it visually better. I have modified it. Thank you

[Luro91]

I was referring to code indentation. With the correct indentation the comments are not needed. indentation is a standard that makes it easy to see visually which elements are on which hierarchy. Tools like the IDE also allow code folding based on indentation

[Luro91]

An advanced topic regarding UX:
At the moment the boxes containing quotes have various sizes depending on the text. This also leads to the button changing the position. (it would be nice if the button would stay in position and the user would not have to move the mouse to click it again).
How could you accomplish this?

[dcostaprakash]

Understood. I made the following changes to incorporate it. I increased the quote-container height and max-width, made the display to flex and further the quote-text i made it to overflow with minimum heing 0 so that it can scroll and not disturb the button. Thanks

[Luro91]

The box size still changes in width and make the button move in horizontal direction.
This is an optional improvement that you could do. In this case the list of quotes is defined so you can design the box for the longest quote and it will fit all of them.

[Luro91]

I only now noticed your commit messages. When I read the commit messages I don't know what the change was.
Commit messages should give everyone an understanding on what was changed in the commit without having to look at the actual file changes. It's also good practice to separate changes into separate commits. (For example one for adjusting the box size and one for changing the html structure)
You can also give context in the message about the reason for the change.

I recommend reading this article on commit messages: https://chris.beams.io/git-commit