Sheffield | ITP-Jan-26 | Mahammad Osman | Sprint 3 | Alarm Clock#1162
Open
Darkidd77 wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
Sheffield | ITP-Jan-26 | Mahammad Osman | Sprint 3 | Alarm Clock#1162Darkidd77 wants to merge 2 commits intoCodeYourFuture:mainfrom
Darkidd77 wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
Darkidd77
added
the
Needs Review
Luro91
added
Review in progress
Luro91
reviewed
Apr 4, 2026
| const headingElement = document.getElementById("timeRemaining"); | ||
|
|
||
| if (!inputElement.value) { | ||
| return; |
There was a problem hiding this comment.
It's important to validate user input.
What happens if a user enters a negative value?
How could you give feedback to the user about the input not being valid?
| }, 1000); | ||
| } | ||
|
|
||
| function flashScreen() { |
There was a problem hiding this comment.
Nice bonus implementation of the flashing screen
Luro91
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
setAlarmfunction.setInterval(1000ms delay).MM:SSusing.padStart(2, '0').clearIntervalboth when the timer hits zero, and if the user clicks "Set Alarm" while a timer is already running.