West Midlands | 26-Jan-ITP | Fida Ali Zada | Sprint 2 | Data Group

[alizada-dev]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Completed the exercises in the Sprint-2 folder

[cjyuan]

Since this loop does not need key, you could consider using the method that returns only an array of property values.

[alizada-dev]

for (const value of Object.values(author)) { console.log(value); }

[cjyuan]

Why check if key is in the same object the loop is iterating though?

[alizada-dev]

for (const key in obj) { if (key == x) { return true } }

[cjyuan]

Does your function return the value you expect from the following function calls?

contains(["a", "b", "c"], "1")
contains("abc", "1")
contains(null, "1")
contains(undefined, "1")

[alizada-dev]

Now, it handles correctly.

[cjyuan]

For each of the following function calls, does your function return the value you expect?

parseQueryString("a=b&=&c=d")
parseQueryString("a=")
parseQueryString("=b")
parseQueryString("a=b&&c=d")
parseQueryString("a%25b=c%26d")

---

Note:

• In real query string, both key and value are percent-encoded or URL encoded in the URL.
  For example, the string "5%" is encoded as "5%25". So to get the actual value of "5%25"
  (whether it is a key or value in the query string), we need to call a function to decode it.

• You can also explore the URLSearchParams API.

[alizada-dev]

`function parseQueryString(queryString) {
const queryParams = {};

if (!queryString) return queryParams;

const keyValuePairs = queryString.split("&");

for (const pair of keyValuePairs) {
// skip empty pairs (e.g. &&)
if (pair === "") continue;

const index = pair.indexOf("=");

let key, value;

if (key === -1) {
  key = pair;
  value = "";
} else {
  key = pair.substring(0, index);
  value = pair.substring(index + 1);
}

// decoding URL
try {
  key = decodeURIComponent(key);
  value = decodeURIComponent(value);
} catch (error) {
  
}

queryParams[key] = value;

}

return queryParams;
}`

[cjyuan]

Can you give a more descriptive error message?

[alizada-dev]

else throw new Error("The input should be an array!");

[cjyuan]

Does the following function call returns the value you expect?

tally(["toString", "toString"]);

Suggestion: Look up an approach to create an empty object with no inherited properties.

[alizada-dev]

`function tally(arr) {
if (!Array.isArray(arr)) {
throw new Error("The input should be an array!");
}

const countObj = Object.create(null);

for (const item of arr) {

    if (countObj[item]) {
        countObj[item] = countObj[item] + 1;
    } else {
        countObj[item] = 1;
    }
}

return countObj;

}`

[cjyuan]

The "target value" refers to the expected value when the function is working correctly.

[alizada-dev]

{1 : 'a', 2: 'b'}

[cjyuan]

Does your function return what you expect in the following function calls?

countWords("Hello,World! Hello World!");
countWords("constructor constructor");
countWords("          Hello World      ");

Note: The spec is not clear about exactly what to expect from these function calls. This is just for self-check.

[cjyuan]

I think the question is asking for the "expected output", not the actual output.

[alizada-dev]

I am sorry, sir, for responding late. I got a job because it was so stressful not working.

[cjyuan]

The proposed changes look good. Have you applied the changes and pushed the changes to GitHub? I don't see any new commits on this PR branch.

[alizada-dev]

I had forgotten to push the changes. I just pushed them.

[cjyuan]

Still nothing new on this branch. Did you push the changes on the right branch?