Skip to content

Sheffield | 26-ITP-Jan | Seti Mussa | Sprint 2 | Form-Control #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Seti-Jemal wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Sheffield | 26-ITP-Jan | Seti Mussa | Sprint 2 | Form-Control #1160

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
89a0a03
Added color options
Seti-Jemal Feb 6, 2026
ccab9cd
Fixed error
Seti-Jemal Feb 6, 2026
a52173e
Add some space
Seti-Jemal Feb 7, 2026
1dde49f
Fixed error
Seti-Jemal Feb 8, 2026
a90e903
Add title name must contain at one space
Seti-Jemal Feb 9, 2026
a7ebc92
Applied review comment and fix validation issues
Seti-Jemal Feb 12, 2026
56b4992
Remove the results.html and update form action
Seti-Jemal Feb 12, 2026
c095254
Added name to footer
Seti-Jemal Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 62 additions & 15 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,73 @@
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<title>Order Form</title>
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="description" content="Simple order form for selecting name, email, color, and size." />
</head>

<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
<main>
<h1>Order Form</h1>
<form action="results.html" method="GET" autocomplete="on">
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Feb 11, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For testing, you can set the action attribute to "#" so that the form data is sent to the same URL.
There is no need to prepare a separate file to accept the submitted data. This way, you don't need to introduce result.html in this repo.

Note: The spec actually says, Do not write a form action for this project.

<div>
<label for="name">Name</label>
<input type="text" name="name" id="name" minlength="2" required autocomplete="name">
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter validation rule using the pattern attribute to disallow any name that contains only space characters?

</div>

<div>
<br>
<label for="email">Email</label>
<input type="email" name="email" id="email" required autocomplete="email">
</div>

<br>
<fieldset>
<legend>Please select a color:</legend>
<div>
<input type="radio" id="black" name="color" value="Black" required autocomplete="off">
<label for ="black"> Black</label>
</div>
<br>
<div>
<input type="radio" id="grey" name="color" value="Grey">
<label for ="grey"> Grey</label>
<br>
</div>
<div>
<br>
<input type="radio" id="red" name="color" value="Red">
<label for ="red"> Red</label>
<br>
</div>

</fieldset>


<fieldset>
<legend>Please select a size:</legend>
<label for="size">Size</label>
<select name="size" id="size" required>
<option value="">Select size</option>
<option value="xs">XS</option>
<option value="s">S</option>
<option value="m">M</option>
<option value="l">L</option>
<option value="xl">XL</option>
<option value="xxl">XXL</option>
</select>
</fieldset>
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you improve the indentation of the code on this file?



<button type="submit">Submit order</button>

</form>
</main>

<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>

<p>Sjc</p>
</footer>
</body>
</html>

40 changes: 40 additions & 0 deletions Form-Controls/results.html
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file for? If it is not a required file in implementing the T-shirt order form, you should delete it to keep the PR branch clean.

Copy link
Copy Markdown
Author

@Seti-Jemal Seti-Jemal Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I deleted the file , the form control stopped working as well.

Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<Form action="results.html" method="GET"
<div>
<label for="name">Name</label>
<input type="text" name="name" id="name" required
</div>
<div>
<label for="email">Email</label>
<input type="email" name="email" required>
</div>
<div>
<label for ="Size">Size</label>
<input type="text" name="size" id="size" required>
</div>
<button type="submit">Submit</button>
</Form>
<h1> </h1>
</header>
<main>

<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>

</main>
<footer>

<h2>Seti Mussa</h2>
</footer>