Skip to content
Open
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 55 additions & 18 deletions Wireframe/index.html
Original file line number Diff line number Diff line change
@@ -1,33 +1,70 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Wireframe</title>
<link rel="stylesheet" href="style.css" />
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Three Key Tech Tips</title>
<link rel="stylesheet" href="style.css">
</head>
<body>
<header>
<h1>Wireframe</h1>
<p>
This is the default, provided code and no changes have been made yet.
<h1>Three Tech Tips</h1>
<p id="p_description">
Here are some useful things to know when learning to create your own websites
and manage tech projects.
</p>
</header>
<main>
<article>
<img src="placeholder.svg" alt="" />
<h2>Title</h2>
<p>
Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam,
voluptates. Quisquam, voluptates.
<img src="https://repository-images.githubusercontent.com/190038729/991a8980-8e28-11e9-9d4f-b0bdf64180f4" alt="Readme">
<h2>The Purpose of a Readme File</h2>
<p id="p_readme">
A readme file is a very important part of any GitHub repository. It is often the first item a visitor will see
when landing on a repository. A readme file should provide users with information about the purpose of a
project, how to use it effectively and who the contributers and maintainers of the project are.
</p>
<a href="">Read more</a>
<a href="https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes"
target="_blank">Read More</a>
</article>
<article>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is slightly off.

It is a good practice to use an code formatting tool such as VSCode's "Format Document" to keep our code consistently formatted before we commit the changes.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks that's a good feature to know about.

<h2>
The Purpose of A Wireframe
</h2>
<img src="https://cdn.nulab.com/learn-wp/app/uploads/2018/10/14210245/Cacoo-8-must-see-wireframes-680x450-1.png" alt="Wireframe">
<p>
A wireframe in web design is a basic visual representation of a webpage
that helps to outline its overall stucture and functionality.
Wireframes are used early in the development process to demonstrate the basic
structure of a page before visual design and content are added. The simplicity
of wireframes allow for changes and iterations to be made quickly and easily.
</p>
<a href="https://www.experienceux.co.uk/faqs/what-is-wireframing/"
target="_blank">Read More</a>
</article>
<article>
<h2>
What is a Git Branch
</h2>
<img src="https://media.licdn.com/dms/image/v2/D4D12AQH6ykM-AVoDKg/article-cover_image-shrink_720_1280/B4DZZW5EzAHAAM-/0/1745214525491?e=2147483647&v=beta&t=kB_Gy_FceQSnp1FMZ2lVvoPis3lrcCQjgX0Zur3z4pc"
alt="Git Branch Model">
<p>
A git branch is a pointer to a snapshot of all the changes that occured
on that branch. Upon creating a new GitHub repository you will usually
be on the main branch by default. You can create additional branches which
are like separate workspaces to make changes to a project or test other features
without compromising the base project. Branches are useful when working
on a project with many collaborators as each individual can make changes on their own local
copy of a project and propose their changes to be integrated to the main branch
after approval.
</p>
<a href="https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell"
target="_blank">Read More</a>
</article>
</main>
<footer>
<p>
This is the default, provided code and no changes have been made yet.
</p>
</footer>
<footer>
<p id="p_footer">
Footer content will go here
</p>
</footer>
</body>
</html>
28 changes: 27 additions & 1 deletion Wireframe/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,35 @@ As well as useful links to learn more */
--font: 100%/1.5 system-ui;
--space: clamp(6px, 6px + 2vw, 15px);
--line: 1px solid;
--line2: 5px solid;
--container: 1280px;
}


/* ====== Base Elements ======
General rules for basic HTML elements in any context */
body {
background: var(--paper);
color: var(--ink);
font: var(--font);
}
h1 {
text-align: center;
font-size: 50px;
}
h2 {
text-align: center;
font-size: 30px;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using relative units for font size (e. g., em, rem, vw, %) is often better than fixed px because they make our design more accessible, flexible, and responsive.

}

#p_readme {
text-align: left;
font-size: 22px;
}
#p_description {
text-align: center;
font-size: 26px;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • p_readme -- This id name would become "outdated" if the first article content changes.
  • p_description -- This id name does not quite describe which paragraph it is identifying.

Can you think of more appropriate names that are more descriptive and are independent of article content?

Alternatively, you can use complex selectors to select the specific <p> element on the page without using id's.

a {
padding: var(--space);
border: var(--line);
Expand All @@ -50,8 +70,14 @@ main {
margin: 0 auto calc(var(--space) * 4) auto;
}
footer {
border: var(--line);
position: fixed;
bottom: 0;
bottom: -2px;
left: 50%;
transform: translateX(-50%);
width: 1280px;
background-color: rgb(202, 160, 160);
border-color: black;
text-align: center;
}
/* ====== Articles Grid Layout ====
Expand Down